Re: [PATCH 5/6] t0021/rot13-filter: add capability functions

2017-11-04 Thread Junio C Hamano
Christian Couder writes: >>> + my ( $res, $buf ) = packet_bin_read(); >>> + return ( $res, @cap ) if ( $res != 0 ); >> >> The original had the same "'list eq list' does not do what you may >> think it does" issue. This one corrects it, which is good. >> >> I am not sure i

Re: [PATCH 5/6] t0021/rot13-filter: add capability functions

2017-11-04 Thread Christian Couder
On Sun, Oct 22, 2017 at 3:46 AM, Junio C Hamano wrote: > Christian Couder writes: > >> Add functions to help read and write capabilities. >> These functions will be reused in following patches. > > One more thing that is more noteworthy (read: do not forget to > describe it in the proposed log me

Re: [PATCH 5/6] t0021/rot13-filter: add capability functions

2017-10-21 Thread Junio C Hamano
Christian Couder writes: > Add functions to help read and write capabilities. > These functions will be reused in following patches. One more thing that is more noteworthy (read: do not forget to describe it in the proposed log message) is that the original used to require capabilities to come i

[PATCH 5/6] t0021/rot13-filter: add capability functions

2017-10-19 Thread Christian Couder
Add functions to help read and write capabilities. These functions will be reused in following patches. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/t/t0021/rot13-filter.p