Re: [PATCH 5/6] rev-list: check reflog_info before showing usage

2017-07-05 Thread Jeff King
On Wed, Jul 05, 2017 at 11:07:35AM -0700, Junio C Hamano wrote: > > This is actually the main "gotcha" I'm worried about with this series. > > I'm not sure if any other code would care about seeing the pending items > > in revs->commits. I still think the series is the right direction; if > > ther

Re: [PATCH 5/6] rev-list: check reflog_info before showing usage

2017-07-05 Thread Junio C Hamano
Jeff King writes: > When git-rev-list sees no pending commits, it shows a usage > message. This works even when reflog-walking is requested, > because the reflog-walk code currently puts the reflog tips > into the pending queue. > > In preparation for refactoring the reflog-walk code, let's > exp

[PATCH 5/6] rev-list: check reflog_info before showing usage

2017-07-05 Thread Jeff King
When git-rev-list sees no pending commits, it shows a usage message. This works even when reflog-walking is requested, because the reflog-walk code currently puts the reflog tips into the pending queue. In preparation for refactoring the reflog-walk code, let's explicitly check whether we have any