Re: [PATCH 5/6] pass st.st_size as hint for strbuf_readlink()

On Wed, Jul 25, 2018 at 08:41:00PM +0200, Torsten Bögershausen wrote: > On Tue, Jul 24, 2018 at 06:51:39AM -0400, Jeff King wrote: > > When we initially added the strbuf_readlink() function in > > b11b7e13f4 (Add generic 'strbuf_readlink()' helper function, > > 2008-12-17), the point was that we g

Re: [PATCH 5/6] pass st.st_size as hint for strbuf_readlink()

On Tue, Jul 24, 2018 at 06:51:39AM -0400, Jeff King wrote: > When we initially added the strbuf_readlink() function in > b11b7e13f4 (Add generic 'strbuf_readlink()' helper function, > 2008-12-17), the point was that we generally have a _guess_ > as to the correct size based on the stat information,

[PATCH 5/6] pass st.st_size as hint for strbuf_readlink()

When we initially added the strbuf_readlink() function in b11b7e13f4 (Add generic 'strbuf_readlink()' helper function, 2008-12-17), the point was that we generally have a _guess_ as to the correct size based on the stat information, but we can't necessarily trust it. Over the years, a few callers