Re: [PATCH 5/6] pack-bitmap: save "have" bitmap from walk

2018-08-31 Thread Jeff King
On Fri, Aug 31, 2018 at 05:23:17PM +0200, Ævar Arnfjörð Bjarmason wrote: > On Tue, Aug 21 2018, Jeff King wrote: > > > +int bitmap_has_sha1_in_uninteresting(struct bitmap_index *bitmap_git, > > +const unsigned char *sha1) > > +{ > > + int pos; > > + > > + if (!

Re: [PATCH 5/6] pack-bitmap: save "have" bitmap from walk

2018-08-31 Thread Ævar Arnfjörð Bjarmason
On Tue, Aug 21 2018, Jeff King wrote: > +int bitmap_has_sha1_in_uninteresting(struct bitmap_index *bitmap_git, > + const unsigned char *sha1) > +{ > + int pos; > + > + if (!bitmap_git) > + return 0; /* no bitmap loaded */ > + if (!bitmap_g

Re: [PATCH 5/6] pack-bitmap: save "have" bitmap from walk

2018-08-21 Thread Jeff King
On Tue, Aug 21, 2018 at 03:47:36PM -0400, Derrick Stolee wrote: > On 8/21/2018 3:07 PM, Jeff King wrote: > > When we do a bitmap walk, we save the result, which > > represents (WANTs & ~HAVEs); i.e., every object we care > > about visiting in our walk. However, we throw away the > > haves bitmap,

Re: [PATCH 5/6] pack-bitmap: save "have" bitmap from walk

2018-08-21 Thread Derrick Stolee
On 8/21/2018 3:07 PM, Jeff King wrote: When we do a bitmap walk, we save the result, which represents (WANTs & ~HAVEs); i.e., every object we care about visiting in our walk. However, we throw away the haves bitmap, which can sometimes be useful, too. Save it and provide an access function so cod

[PATCH 5/6] pack-bitmap: save "have" bitmap from walk

2018-08-21 Thread Jeff King
When we do a bitmap walk, we save the result, which represents (WANTs & ~HAVEs); i.e., every object we care about visiting in our walk. However, we throw away the haves bitmap, which can sometimes be useful, too. Save it and provide an access function so code which has performed a walk can query it

Re: [PATCH 5/6] pack-bitmap: save "have" bitmap from walk

2018-08-17 Thread Jeff King
On Fri, Aug 17, 2018 at 03:39:29PM -0700, Stefan Beller wrote: > > diff --git a/pack-bitmap.h b/pack-bitmap.h > > index 4555907dee..02a60ce670 100644 > > --- a/pack-bitmap.h > > +++ b/pack-bitmap.h > > @@ -50,6 +50,13 @@ int rebuild_existing_bitmaps(struct bitmap_index *, > > struct packing_data

Re: [PATCH 5/6] pack-bitmap: save "have" bitmap from walk

2018-08-17 Thread Stefan Beller
> diff --git a/pack-bitmap.h b/pack-bitmap.h > index 4555907dee..02a60ce670 100644 > --- a/pack-bitmap.h > +++ b/pack-bitmap.h > @@ -50,6 +50,13 @@ int rebuild_existing_bitmaps(struct bitmap_index *, struct > packing_data *mapping > khash_sha1 *reused_bitmaps, int show

[PATCH 5/6] pack-bitmap: save "have" bitmap from walk

2018-08-17 Thread Jeff King
When we do a bitmap walk, we save the result, which represents (WANTs & ~HAVEs); i.e., every object we care about visiting in our walk. However, we throw away the haves bitmap, which can sometimes be useful, too. Save it and provide an access function so code which has performed a walk can query it

[PATCH 5/6] pack-bitmap: save "have" bitmap from walk

2014-03-26 Thread Jeff King
When we do a bitmap walk, we save the result, which represents (WANTs & ~HAVEs); i.e., every object we care about visiting in our walk. However, we throw away the haves bitmap, which can sometimes be useful, too. Save it and provide an access function so code which has performed a walk can query it