Re: [PATCH 5/5] refs.c: drop curate_packed_refs

2015-03-19 Thread Eric Sunshine
On Tue, Mar 17, 2015 at 3:31 AM, Jeff King wrote: > When we delete a ref, we have to rewrite the entire > packed-refs file. We take this opportunity to "curate" the > packed-refs file and drop any entries that are crufty or > broken. > > Dropping broken entries (e.g., with bogus names, or ones > t

[PATCH 5/5] refs.c: drop curate_packed_refs

2015-03-17 Thread Jeff King
When we delete a ref, we have to rewrite the entire packed-refs file. We take this opportunity to "curate" the packed-refs file and drop any entries that are crufty or broken. Dropping broken entries (e.g., with bogus names, or ones that point to missing objects) is actively a bad idea, as it mean