Johannes Schindelin writes:
> Well, if I change `rev.diffopt.use_color != GIT_COLOR_ALWAYS` to
> `rev.diffopt.use_color == GIT_COLOR_AUTO`, then the files will contain
> ugly ANSI color sequences if I run `git format-patch -o . -3`.
>
> The reason is, as I tried to explain, that the use_color fie
Johannes Schindelin writes:
> Well, if I change `rev.diffopt.use_color != GIT_COLOR_ALWAYS` to
> `rev.diffopt.use_color == GIT_COLOR_AUTO`, then the files will contain
> ugly ANSI color sequences if I run `git format-patch -o . -3`.
>
> The reason is, as I tried to explain, that the use_color fie
Hi Junio,
On Wed, 22 Jun 2016, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > But there's a rub... If you specify --color *explicitly*, use_color is set
> > to GIT_COLOR_ALWAYS and the file indeed contains ANSI sequences (i.e. my
> > analysis above left out the command-line part).
>
Johannes Schindelin writes:
> But there's a rub... If you specify --color *explicitly*, use_color is set
> to GIT_COLOR_ALWAYS and the file indeed contains ANSI sequences (i.e. my
> analysis above left out the command-line part).
Heh, the command-line is the _ONLY_ thing I raised, as we knew
ui.
Hi Junio,
On Tue, 21 Jun 2016, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > That is a very convincing argument. So convincing that I wanted to change
> > the patch to guard behind `diff_use_color_default == GIT_COLOR_AUTO`.
>
> I actually was expecting, instead of your:
>
>
Johannes Schindelin writes:
> That is a very convincing argument. So convincing that I wanted to change
> the patch to guard behind `diff_use_color_default == GIT_COLOR_AUTO`.
I actually was expecting, instead of your:
if (output_directory) {
+ rev.diffopt.use_color = 0;
Hi Junio,
On Mon, 20 Jun 2016, Junio C Hamano wrote:
> You can probably sell "when giving out put to file, we will never color
> the output" as an improved new world order, but if that is what this
> change wants to do, it probably deserves a separate patch.
>
> I however think you can avoid bre
Johannes Schindelin writes:
> When format-patch calls the diff machinery, want_color() is used to
> determine whether to use ANSI color sequences or not. If use_color is not
> set explicitly, isatty(1) is used to determine whether or not the user
> wants color. When stdout was freopen()ed, this i
Hi Eric,
On Mon, 20 Jun 2016, Eric Sunshine wrote:
> On Mon, Jun 20, 2016 at 2:26 AM, Johannes Schindelin
> wrote:
> > On Sun, 19 Jun 2016, Eric Sunshine wrote:
> >> On Sat, Jun 18, 2016 at 6:04 AM, Johannes Schindelin
> >> wrote:
> >> > if (output_directory) {
> >> > + re
On Mon, Jun 20, 2016 at 2:26 AM, Johannes Schindelin
wrote:
> On Sun, 19 Jun 2016, Eric Sunshine wrote:
>> On Sat, Jun 18, 2016 at 6:04 AM, Johannes Schindelin
>> wrote:
>> > if (output_directory) {
>> > + rev.diffopt.use_color = 0;
>>
>> What is this change about? It doesn'
Hi Eric,
On Sun, 19 Jun 2016, Eric Sunshine wrote:
> On Sat, Jun 18, 2016 at 6:04 AM, Johannes Schindelin
> wrote:
> > We just taught the relevant functions to respect the diffopt.file field,
> > to allow writing somewhere else than stdout. Let's make use of it.
> > [...]
> > Signed-off-by: Joha
On Sat, Jun 18, 2016 at 6:04 AM, Johannes Schindelin
wrote:
> We just taught the relevant functions to respect the diffopt.file field,
> to allow writing somewhere else than stdout. Let's make use of it.
> [...]
> Signed-off-by: Johannes Schindelin
> ---
> diff --git a/builtin/log.c b/builtin/log
We just taught the relevant functions to respect the diffopt.file field,
to allow writing somewhere else than stdout. Let's make use of it.
Technically, we do not need to avoid that call in a builtin: we assume
that builtins (as opposed to library functions) are stand-alone programs
that may do wi
13 matches
Mail list logo
