Re: [PATCH 46/67] write_loose_object: convert to strbuf

On Wed, Sep 16, 2015 at 02:27:57PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > - memcpy(buffer, filename, dirlen); > > - strcpy(buffer + dirlen, "tmp_obj_XX"); > > - fd = git_mkstemp_mode(buffer, 0444); > > + strbuf_reset(tmp); > > + strbuf_add(tmp, filename, dirlen); >

Re: [PATCH 46/67] write_loose_object: convert to strbuf

Jeff King writes: > - memcpy(buffer, filename, dirlen); > - strcpy(buffer + dirlen, "tmp_obj_XX"); > - fd = git_mkstemp_mode(buffer, 0444); > + strbuf_reset(tmp); > + strbuf_add(tmp, filename, dirlen); > + strbuf_addstr(tmp, "tmp_obj_XX"); > + fd = git_mkstemp_

[PATCH 46/67] write_loose_object: convert to strbuf

When creating a loose object tempfile, we use a fixed PATH_MAX-sized buffer, and strcpy directly into it. This isn't buggy, because we do a rough check of the size, but there's no verification that our guesstimate of the required space is enough (in fact, it's several bytes too big for the current