Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case

On Wed, Oct 10, 2012 at 12:31 PM, Junio C Hamano wrote: > Nguyen Thai Ngoc Duy writes: > >> Git's ctype does not seem to be complete for wildmatch's use so >> ctype.h is required. But that can be easily fixed later on. > > Until "later on", I cannot even compile the series. So that's why you not

Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case

Nguyen Thai Ngoc Duy writes: > Git's ctype does not seem to be complete for wildmatch's use so > ctype.h is required. But that can be easily fixed later on. Until "later on", I cannot even compile the series. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a mess

Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case

On Wed, Oct 10, 2012 at 3:47 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> diff --git a/wildmatch.c b/wildmatch.c >> index 7b64a6b..2382873 100644 >> --- a/wildmatch.c >> +++ b/wildmatch.c >> @@ -11,8 +11,8 @@ >> >> #include >> #include >> -#include >> >> +#include "cache.h"

Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case

Nguyễn Thái Ngọc Duy writes: > diff --git a/wildmatch.c b/wildmatch.c > index 7b64a6b..2382873 100644 > --- a/wildmatch.c > +++ b/wildmatch.c > @@ -11,8 +11,8 @@ > > #include > #include > -#include > > +#include "cache.h" > #include "wildmatch.h" This is wrong; the includes from the s

[PATCH 4/8] wildmatch: remove static variable force_lower_case

One place less to worry about thread safety. Also combine wildmatch and iwildmatch into one. Signed-off-by: Nguyễn Thái Ngọc Duy --- test-wildmatch.c | 4 ++-- wildmatch.c | 23 ++- wildmatch.h | 3 +-- 3 files changed, 9 insertions(+), 21 deletions(-) diff --git