Re: [PATCH 4/8] perf/run: use $default_value instead of $4

On Wed, Dec 13, 2017 at 9:54 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> If you want to be able to use this helper to specify a default value >> of an empty string (which the orignal that used $4 did), then the >> previous hunk must be corrected so that it does not unconditionally >>

Re: [PATCH 4/8] perf/run: use $default_value instead of $4

On Wed, Dec 13, 2017 at 9:40 PM, Junio C Hamano wrote: > Christian Couder writes: > >> Signed-off-by: Christian Couder >> --- >> t/perf/run | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/t/perf/run b/t/perf/run >> index 43e4de49ef..bbd703dc4f 100755 >> --- a/t/p

Re: [PATCH 4/8] perf/run: use $default_value instead of $4

Junio C Hamano writes: > If you want to be able to use this helper to specify a default value > of an empty string (which the orignal that used $4 did), then the > previous hunk must be corrected so that it does not unconditionally > set default_value to $4. Perhaps like > > if test -n "${

Re: [PATCH 4/8] perf/run: use $default_value instead of $4

Christian Couder writes: > Signed-off-by: Christian Couder > --- > t/perf/run | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/perf/run b/t/perf/run > index 43e4de49ef..bbd703dc4f 100755 > --- a/t/perf/run > +++ b/t/perf/run > @@ -105,7 +105,7 @@ get_var_from_env_o

[PATCH 4/8] perf/run: use $default_value instead of $4

Signed-off-by: Christian Couder --- t/perf/run | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/perf/run b/t/perf/run index 43e4de49ef..bbd703dc4f 100755 --- a/t/perf/run +++ b/t/perf/run @@ -105,7 +105,7 @@ get_var_from_env_or_config () { env_var="$1" con