Re: [PATCH 4/7] Handle missing HTTP_CONNECTCODE in curl < 7.10.7

2017-04-05 Thread Franke, Knut
On 2017-04-05 15:50, Ævar Arnfjörð Bjarmason wrote: > This effectively disables that code & this later check: > > + if (results->http_connectcode == 407) > + credential_reject(&proxy_auth); > > What's the impact of not taking that branch when the proxy returns

Re: [PATCH 4/7] Handle missing HTTP_CONNECTCODE in curl < 7.10.7

2017-04-05 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 5, 2017 at 3:04 PM, Tom G. Christensen wrote: > With curl < 7.10.7 we cannot get the proxy CONNECT response code. > As a workaround set it to zero which means no response code available. CC-ing Knut Franke which added this code in 372370f167. This effectively disables that code & th

[PATCH 4/7] Handle missing HTTP_CONNECTCODE in curl < 7.10.7

2017-04-05 Thread Tom G. Christensen
With curl < 7.10.7 we cannot get the proxy CONNECT response code. As a workaround set it to zero which means no response code available. Signed-off-by: Tom G. Christensen --- http.c | 4 1 file changed, 4 insertions(+) diff --git a/http.c b/http.c index 96d84bbed..ce618bdca 100644 --- a/ht