Re: [PATCH 4/6] send-pack: improve unpack-status error messages

2017-03-08 Thread Junio C Hamano
Jeff King writes: >> > And finally, neither message was marked for translation. The >> > message from the remote probably won't be translated, but >> > there's no reason we can't do better for the local half. >> >> Hmm, OK. > > I'll admit that I don't actually use the translations myself, being

Re: [PATCH 4/6] send-pack: improve unpack-status error messages

2017-03-08 Thread Jeff King
On Tue, Mar 07, 2017 at 02:56:27PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > When the remote tells us that the "unpack" step failed, we > > show an error message. However, unless you are familiar with > > the internals of send-pack and receive-pack, it was not > > clear that this re

Re: [PATCH 4/6] send-pack: improve unpack-status error messages

2017-03-07 Thread Junio C Hamano
Jeff King writes: > When the remote tells us that the "unpack" step failed, we > show an error message. However, unless you are familiar with > the internals of send-pack and receive-pack, it was not > clear that this represented an error on the remote side. > Let's re-word to make that more obvi

[PATCH 4/6] send-pack: improve unpack-status error messages

2017-03-07 Thread Jeff King
When the remote tells us that the "unpack" step failed, we show an error message. However, unless you are familiar with the internals of send-pack and receive-pack, it was not clear that this represented an error on the remote side. Let's re-word to make that more obvious. Likewise, when we got an