Re: [PATCH 4/6] fsmonitor: Add a trailing newline to test-dump-fsmonitor

2017-12-21 Thread Junio C Hamano
Alex Vandiver writes: > The only current uses of this tool are in tests, which only examine > the first ("no fsmonitor" / "fsmonitor last update ...") line. I find > it useful as a brief summary view of the fsmonitor bits, but I suppose > I'd also be happy with just presence/absence and a count

Re: [PATCH 4/6] fsmonitor: Add a trailing newline to test-dump-fsmonitor

2017-12-20 Thread Alex Vandiver
On Tue, 19 Dec 2017, Junio C Hamano wrote: > That (and existing) uses of printf() all feel a bit overkill ;-) > Perhaps putchar() would suffice. > > I am not sure if the above wants to become something like > > for (i = 0; i < istate->cache_nr; i++) { > putchar(istate->cache[

Re: [PATCH 4/6] fsmonitor: Add a trailing newline to test-dump-fsmonitor

2017-12-19 Thread Junio C Hamano
Alex Vandiver writes: > Subject: Re: [PATCH 4/6] fsmonitor: Add a trailing newline to > test-dump-fsmonitor "Subject: fsmonitor: complete the last line of test-dump-fsmonitor output" perhaps. > This makes it more readable when used for debugging from the > commandl