Re: [PATCH 4/5] update_unicode.sh: Make the output structure visible

2014-12-19 Thread Jeff King
On Fri, Dec 19, 2014 at 04:43:51PM +0100, Beat Bolli wrote: > I think the code looks much nicer with a here doc. > > Checking in t/, it looks that there's no consensus about whether to > indent the content relative to the cat statement or not. What do you > suggest? I think we typically do it at

Re: [PATCH 4/5] update_unicode.sh: Make the output structure visible

2014-12-19 Thread Beat Bolli
On 19.12.14 16:22, Jeff King wrote: > On Fri, Dec 19, 2014 at 03:39:30PM +0100, dev+...@drbeat.li wrote: > >> By using printf instead of the echo/uniset sequence, the final structure >> of the generated file becomes obvious. > > This whole series looks pretty sane to me, and the result is easier

Re: [PATCH 4/5] update_unicode.sh: Make the output structure visible

2014-12-19 Thread Jeff King
On Fri, Dec 19, 2014 at 03:39:30PM +0100, dev+...@drbeat.li wrote: > By using printf instead of the echo/uniset sequence, the final structure > of the generated file becomes obvious. This whole series looks pretty sane to me, and the result is easier to read. I did wonder if a here-doc would be

[PATCH 4/5] update_unicode.sh: Make the output structure visible

2014-12-19 Thread dev+git
From: Beat Bolli By using printf instead of the echo/uniset sequence, the final structure of the generated file becomes obvious. Signed-off-by: Beat Bolli --- update_unicode.sh | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/update_unicode.sh b/update_un