Re: [PATCH 4/5] index-pack: report correct bad object offsets even if they are large

2016-07-12 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > va_end(params); > - die(_("pack has bad object at offset %lu: %s"), offset, buf); > + die(_("pack has bad object at offset %"PRIiMAX": %s"), > + (intmax_t)offset, buf); Subject: [PATCH] SQUASH??? diff --git a/builtin/index-pack.c b/builtin/i

Re: [PATCH 4/5] index-pack: report correct bad object offsets even if they are large

2016-07-12 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Use the right type for offsets in this case, off_t, which makes a > difference on 32-bit systems with large file support, and change > formatting code accordingly. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > builtin/index-pack.c | 7 --- > 1 file changed,

[PATCH 4/5] index-pack: report correct bad object offsets even if they are large

2016-07-05 Thread Nguyễn Thái Ngọc Duy
Use the right type for offsets in this case, off_t, which makes a difference on 32-bit systems with large file support, and change formatting code accordingly. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/index-pack.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/