Re: [PATCH 4/5] branch_get: provide per-branch pushremote pointers

2014-01-08 Thread Jeff King
On Wed, Jan 08, 2014 at 05:27:07AM -0500, Jeff King wrote: > This patch passes the test suite by itself (with or without that fixup). > But oddly, it seems to fail t5531 when merged with 'next'. I can't > figure out why, though. It shouldn't affect any code that doesn't look > at branch->pushremot

Re: [PATCH 4/5] branch_get: provide per-branch pushremote pointers

2014-01-08 Thread Jeff King
On Wed, Jan 08, 2014 at 04:35:31AM -0500, Jeff King wrote: > @@ -385,8 +387,11 @@ static int handle_config(const char *key, const char > *value, void *cb) > name = key + 7; > > /* Handle remote.* variables */ > - if (!strcmp(name, "pushdefault")) > - return git_confi

[PATCH 4/5] branch_get: provide per-branch pushremote pointers

2014-01-08 Thread Jeff King
When a caller uses branch_get to retrieve a "struct branch", they get the per-branch remote name and a pointer to the remote struct. However, they have no way of knowing about the per-branch pushremote from this interface. Let's expose that information via fields similar to "remote" and "remote_na