Re: [PATCH 4/4] unpack-trees: support super-prefix option

2017-01-11 Thread Stefan Beller
On Wed, Jan 11, 2017 at 3:28 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> Preparing the expected output "expect" outside test_expect_success >>> block is also old-school. Move it inside the new test? >> >> I looked into that. What is our current stance on using single/double quotes? >

Re: [PATCH 4/4] unpack-trees: support super-prefix option

2017-01-11 Thread Junio C Hamano
Stefan Beller writes: >> Preparing the expected output "expect" outside test_expect_success >> block is also old-school. Move it inside the new test? > > I looked into that. What is our current stance on using single/double quotes? Using dq around executable part, i.e. test_expect_succ

Re: [PATCH 4/4] unpack-trees: support super-prefix option

2017-01-11 Thread Stefan Beller
On Wed, Jan 11, 2017 at 1:32 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Add support for the super-prefix option for commands that unpack trees. >> For testing purposes enable it in read-tree, which has no other path >> related output. > > "path related output"? I am not sure I unders

Re: [PATCH 4/4] unpack-trees: support super-prefix option

2017-01-11 Thread Junio C Hamano
Stefan Beller writes: > Add support for the super-prefix option for commands that unpack trees. > For testing purposes enable it in read-tree, which has no other path > related output. "path related output"? I am not sure I understand this. When read-tree reads N trees, or unpack_trees() is as

[PATCH 4/4] unpack-trees: support super-prefix option

2017-01-09 Thread Stefan Beller
Add support for the super-prefix option for commands that unpack trees. For testing purposes enable it in read-tree, which has no other path related output. Signed-off-by: Stefan Beller --- git.c | 2 +- t/t1001-read-tree-m-2way.sh | 9 + unpack-trees.c