Re: [PATCH 4/4] remote: use remote_is_configured() for add and rename

2016-02-17 Thread Johannes Schindelin
Hi Tomas, On Wed, 17 Feb 2016, Thomas Gummerer wrote: > On 02/17, Johannes Schindelin wrote: > > > > diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh > > index 94079a0..19e8e34 100755 > > --- a/t/t5505-remote.sh > > +++ b/t/t5505-remote.sh > > @@ -51,6 +51,11 @@ test_expect_success setup ' > >

Re: [PATCH 4/4] remote: use remote_is_configured() for add and rename

2016-02-17 Thread Thomas Gummerer
On 02/17, Johannes Schindelin wrote: > Hi Peff & Thomas, > > On Mon, 15 Feb 2016, Jeff King wrote: > > This original is quite confusing. I thought at first that there was > > perhaps something going on with allowing repeated re-configuration of > > the same remote, as long as some parameters matche

Re: [PATCH 4/4] remote: use remote_is_configured() for add and rename

2016-02-17 Thread Johannes Schindelin
Hi Peff & Thomas, On Mon, 15 Feb 2016, Jeff King wrote: > On Mon, Feb 15, 2016 at 06:42:30PM +0100, Thomas Gummerer wrote: > > > Both remote add and remote rename use a slightly different hand-rolled > > check if the remote exits. The hand-rolled check may have some subtle > > cases in which it

Re: [PATCH 4/4] remote: use remote_is_configured() for add and rename

2016-02-15 Thread Thomas Gummerer
On 02/15, Jeff King wrote: > On Mon, Feb 15, 2016 at 06:42:30PM +0100, Thomas Gummerer wrote: > > > Both remote add and remote rename use a slightly different hand-rolled > > check if the remote exits. The hand-rolled check may have some subtle > > cases in which it might fail to detect when a rem

Re: [PATCH 4/4] remote: use remote_is_configured() for add and rename

2016-02-15 Thread Jeff King
On Mon, Feb 15, 2016 at 06:42:30PM +0100, Thomas Gummerer wrote: > Both remote add and remote rename use a slightly different hand-rolled > check if the remote exits. The hand-rolled check may have some subtle > cases in which it might fail to detect when a remote already exists. > One such case

[PATCH 4/4] remote: use remote_is_configured() for add and rename

2016-02-15 Thread Thomas Gummerer
Both remote add and remote rename use a slightly different hand-rolled check if the remote exits. The hand-rolled check may have some subtle cases in which it might fail to detect when a remote already exists. One such case was fixed in fb86e32 ("git remote: allow adding remotes agreeing with url.