Re: [PATCH 4/4] ALLOC_GROW: avoid -Wsign-compare warnings

2017-09-22 Thread Ramsay Jones
On 22/09/17 17:25, SZEDER Gábor wrote: > > At first I was somewhat puzzled by the "ALLOC_GROW:" prefix in the > subject line, because this patch doesn't touch ALLOC_GROW() at all. > However, since ALLOC_GROW() is a macro, of course, and since this > patch changes the data type of variables "pass

Re: [PATCH 4/4] ALLOC_GROW: avoid -Wsign-compare warnings

2017-09-22 Thread SZEDER Gábor
At first I was somewhat puzzled by the "ALLOC_GROW:" prefix in the subject line, because this patch doesn't touch ALLOC_GROW() at all. However, since ALLOC_GROW() is a macro, of course, and since this patch changes the data type of variables "passed" to ALLOC_GROW(), that's sort of fine... But th

Re: [PATCH 4/4] ALLOC_GROW: avoid -Wsign-compare warnings

2017-09-22 Thread Ramsay Jones
On 22/09/17 05:20, Junio C Hamano wrote: >> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c >> index a57b4f058..a6ee653bf 100644 >> --- a/builtin/pack-objects.c >> +++ b/builtin/pack-objects.c >> @@ -2563,8 +2563,8 @@ struct in_pack_object { >> }; >> >> struct in_pack { >> -i

Re: [PATCH 4/4] ALLOC_GROW: avoid -Wsign-compare warnings

2017-09-21 Thread Junio C Hamano
Ramsay Jones writes: > Signed-off-by: Ramsay Jones > --- > builtin/pack-objects.c | 4 ++-- > config.c | 2 +- > diff.c | 2 +- > line-log.c | 18 +- > line-log.h | 2 +- > revision.c | 2 +- > tree-walk.c

[PATCH 4/4] ALLOC_GROW: avoid -Wsign-compare warnings

2017-09-21 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- builtin/pack-objects.c | 4 ++-- config.c | 2 +- diff.c | 2 +- line-log.c | 18 +- line-log.h | 2 +- revision.c | 2 +- tree-walk.c| 3 +-- 7 files changed, 16 i