Re: [PATCH 4/3] completion: quote completions we find

2012-09-27 Thread SZEDER Gábor
On Thu, Sep 27, 2012 at 03:31:10PM -0700, Junio C Hamano wrote: > SZEDER Gábor writes: > > > On Wed, Sep 26, 2012 at 05:57:00PM -0400, Jeff King wrote: > >> + COMPREPLY[$i]="${COMPREPLY[$i]}$stripped" > > > > This reminded me to a mini-series collecting dust in my git repo, > > which con

Re: [PATCH 4/3] completion: quote completions we find

2012-09-27 Thread Junio C Hamano
SZEDER Gábor writes: > On Wed, Sep 26, 2012 at 05:57:00PM -0400, Jeff King wrote: >> +COMPREPLY[$i]="${COMPREPLY[$i]}$stripped" > > This reminded me to a mini-series collecting dust in my git repo, > which converts a few similar var=$var$something constructs to use the > += append ope

Re: [PATCH 4/3] completion: quote completions we find

2012-09-27 Thread SZEDER Gábor
On Wed, Sep 26, 2012 at 05:57:00PM -0400, Jeff King wrote: > + COMPREPLY[$i]="${COMPREPLY[$i]}$stripped" This reminded me to a mini-series collecting dust in my git repo, which converts a few similar var=$var$something constructs to use the += append operator instead. Now, Bash suppor

[PATCH 4/3] completion: quote completions we find

2012-09-26 Thread Jeff King
On Wed, Sep 26, 2012 at 05:51:19PM -0400, Jeff King wrote: > This is not a complete fix, as the completion result does > will still contain metacharacters, so it would need extra > quoting to actually be used on a command line. But it's > still a step in the right direction, because: > [...] > 2