Re: [PATCH 31/41] wt-status: convert two uses of EMPTY_TREE_SHA1_HEX

2018-04-30 Thread brian m. carlson
On Tue, Apr 24, 2018 at 12:03:35PM +0200, Martin Ågren wrote: > Just a thought: Maybe it would make sense to have a function > `oid_hex_empty_tree()` or similar to replace the > oid_to_hex[_r](the_hash_algo->empty_tree) idiom. It would help avoid the > buffer here, but also get rid of a few instanc

Re: [PATCH 31/41] wt-status: convert two uses of EMPTY_TREE_SHA1_HEX

2018-04-24 Thread Martin Ågren
On 24 April 2018 at 01:39, brian m. carlson wrote: > Convert two uses of EMPTY_TREE_SHA1_HEX to use oid_to_hex_r and > the_hash_algo to avoid a dependency on a given hash algorithm. Use > oid_to_hex_r in preference to oid_to_hex because the buffer needs to > last through several function calls wh

[PATCH 31/41] wt-status: convert two uses of EMPTY_TREE_SHA1_HEX

2018-04-23 Thread brian m. carlson
Convert two uses of EMPTY_TREE_SHA1_HEX to use oid_to_hex_r and the_hash_algo to avoid a dependency on a given hash algorithm. Use oid_to_hex_r in preference to oid_to_hex because the buffer needs to last through several function calls which might exhaust the limit of four static buffers. Signed-