Re: [PATCH 3/9] help: use early config when autocorrecting aliases

2017-06-09 Thread Junio C Hamano
Johannes Schindelin writes: > This is slightly less performant than the previous way, as the early > config is used *twice*: once to see whether the command refers to an > alias, and then to see what aliases are most similar. However, this is > hardly a performance-critical code path, so performa

Re: [PATCH 3/9] help: use early config when autocorrecting aliases

2017-06-08 Thread Johannes Schindelin
Hi Brandon, On Wed, 7 Jun 2017, Brandon Williams wrote: > On 06/07, Johannes Schindelin wrote: > > Git has this feature where suggests similar commands (including aliases) > > nit: s/where/which/ > > > in case that the user specified an unknown command. > > s/that// Oh my. Thank you so much!

Re: [PATCH 3/9] help: use early config when autocorrecting aliases

2017-06-07 Thread Brandon Williams
On 06/07, Johannes Schindelin wrote: > Git has this feature where suggests similar commands (including aliases) nit: s/where/which/ > in case that the user specified an unknown command. s/that// > > This feature currently relies on a side effect of the way we expand > aliases right now: when a

[PATCH 3/9] help: use early config when autocorrecting aliases

2017-06-07 Thread Johannes Schindelin
Git has this feature where suggests similar commands (including aliases) in case that the user specified an unknown command. This feature currently relies on a side effect of the way we expand aliases right now: when a command is not a builtin, we use the regular config machinery (meaning: discove