Re: [PATCH 3/8] ls_colors.c: enable coloring on u+x files

2014-03-21 Thread Duy Nguyen
On Fri, Mar 21, 2014 at 12:41 AM, Junio C Hamano wrote: > Why even include cache.h for S_IXUSR? > > In the context of the patch I see S_ISGID mentioned and other S_* > st_mode things are already in use in this function before this step, > and presumably you are using them without problems, no? My

Re: [PATCH 3/8] ls_colors.c: enable coloring on u+x files

2014-03-20 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Mar 20, 2014 at 6:46 PM, Matthieu Moy > wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git >>> is concerned, we only care one executable bit. Hard code it. >> >> Why not use S_IXUSR instead of a hardc

Re: [PATCH 3/8] ls_colors.c: enable coloring on u+x files

2014-03-20 Thread Duy Nguyen
On Thu, Mar 20, 2014 at 6:46 PM, Matthieu Moy wrote: > Nguyễn Thái Ngọc Duy writes: > >> git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git >> is concerned, we only care one executable bit. Hard code it. > > Why not use S_IXUSR instead of a hardcoded value? (already used in >

Re: [PATCH 3/8] ls_colors.c: enable coloring on u+x files

2014-03-20 Thread Matthieu Moy
Nguyễn Thái Ngọc Duy writes: > git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git > is concerned, we only care one executable bit. Hard code it. Why not use S_IXUSR instead of a hardcoded value? (already used in path.c, so shouldn't be a problem wrt portability) -- Matthieu

[PATCH 3/8] ls_colors.c: enable coloring on u+x files

2014-03-20 Thread Nguyễn Thái Ngọc Duy
git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git is concerned, we only care one executable bit. Hard code it. Signed-off-by: Nguyễn Thái Ngọc Duy --- ls_colors.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ls_colors.c b/ls_colors.c index d492ab3..