Duy Nguyen writes:
> Although we could make it clear by saying "5 paths updated, 2 deleted"
> (but that may make us say "3 paths added" as well, hmm). Or maybe just
> "%d paths updated" where updates include file creation and deletion.
Yeah, the last one is the simplest and good.
On Tue, Dec 11, 2018 at 3:28 AM Junio C Hamano wrote:
>
> Duy Nguyen writes:
>
> >> + if (ce->ce_flags & CE_WT_REMOVE) {
> >> + if (topath)
> >> + BUG("Can't remove entry to a path");
> >> + unlink_entry(ce);
> >> + return 0;
>
On 12/10, Elijah Newren wrote:
> On Sun, Dec 9, 2018 at 12:05 PM Thomas Gummerer wrote:
> >
> > 'checkout_entry()' currently only supports creating new entries in the
> > working tree, but not deleting them. Add the ability to remove
> > entries at the same time if the entry is marked with the CE
Duy Nguyen writes:
>> + if (ce->ce_flags & CE_WT_REMOVE) {
>> + if (topath)
>> + BUG("Can't remove entry to a path");
>> + unlink_entry(ce);
>> + return 0;
>> + }
>
> This makes the path counting in nd/checkout-noisy less
On Sun, Dec 9, 2018 at 12:05 PM Thomas Gummerer wrote:
>
> 'checkout_entry()' currently only supports creating new entries in the
> working tree, but not deleting them. Add the ability to remove
> entries at the same time if the entry is marked with the CE_WT_REMOVE
> flag.
>
> Currently this doe
On Sun, Dec 9, 2018 at 9:05 PM Thomas Gummerer wrote:
>
> 'checkout_entry()' currently only supports creating new entries in the
> working tree, but not deleting them. Add the ability to remove
> entries at the same time if the entry is marked with the CE_WT_REMOVE
> flag.
>
> Currently this does
'checkout_entry()' currently only supports creating new entries in the
working tree, but not deleting them. Add the ability to remove
entries at the same time if the entry is marked with the CE_WT_REMOVE
flag.
Currently this doesn't have any effect, as the CE_WT_REMOVE flag is
only used in unpack
7 matches
Mail list logo