Re: [PATCH 3/7] trace: use warning() for printing trace errors

2016-08-05 Thread Junio C Hamano
Christian Couder writes: > On Thu, Aug 4, 2016 at 11:28 PM, Junio C Hamano wrote: >> Jeff King writes: >> >>> I wondered if that would then let us drop set_warn_routine(), but it >>> looks like there are other warning() calls it cares about. So that would >>> invalidate the last paragraph here,

Re: [PATCH 3/7] trace: use warning() for printing trace errors

2016-08-05 Thread Christian Couder
On Thu, Aug 4, 2016 at 11:28 PM, Junio C Hamano wrote: > Jeff King writes: > >> I wondered if that would then let us drop set_warn_routine(), but it >> looks like there are other warning() calls it cares about. So that would >> invalidate the last paragraph here, though I still think converting t

Re: [PATCH 3/7] trace: use warning() for printing trace errors

2016-08-05 Thread Jeff King
On Thu, Aug 04, 2016 at 02:28:09PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > I wondered if that would then let us drop set_warn_routine(), but it > > looks like there are other warning() calls it cares about. So that would > > invalidate the last paragraph here, though I still think

Re: [PATCH 3/7] trace: use warning() for printing trace errors

2016-08-04 Thread Junio C Hamano
Jeff King writes: > I wondered if that would then let us drop set_warn_routine(), but it > looks like there are other warning() calls it cares about. So that would > invalidate the last paragraph here, though I still think converting the > trace errors to warning() is a reasonable thing to do. Y

Re: [PATCH 3/7] trace: use warning() for printing trace errors

2016-08-04 Thread Jeff King
On Thu, Aug 04, 2016 at 01:41:02PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Right now we just fprintf() straight to stderr, which can > > make the output hard to distinguish. It would be helpful to > > give it one of our usual prefixes like "error:", "warning:", > > etc. > > > > It

Re: [PATCH 3/7] trace: use warning() for printing trace errors

2016-08-04 Thread Junio C Hamano
Jeff King writes: > Right now we just fprintf() straight to stderr, which can > make the output hard to distinguish. It would be helpful to > give it one of our usual prefixes like "error:", "warning:", > etc. > > It doesn't make sense to use error() here, as the trace code > is "optional" debugg

[PATCH 3/7] trace: use warning() for printing trace errors

2016-08-03 Thread Jeff King
Right now we just fprintf() straight to stderr, which can make the output hard to distinguish. It would be helpful to give it one of our usual prefixes like "error:", "warning:", etc. It doesn't make sense to use error() here, as the trace code is "optional" debugging code. If something goes wrong