Stefan Beller wrote:
> +++ b/run-command.h
> @@ -159,7 +159,7 @@ typedef int (*get_next_task_fn)(struct child_process *cp,
> * the negative signal number.
> */
> typedef int (*start_failure_fn)(struct child_process *cp,
> - struct strbuf *err,
> +
The refs code has a similar pattern of passing around 'struct strbuf *err',
which is strictly used for error reporting. This is not the case here,
as the strbuf is used to accumulate all the output (whether it is error
or not) for the user. Rename it to 'out'.
Suggested-by: Jonathan Nieder
Signed
2 matches
Mail list logo