Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-05-06 Thread Junio C Hamano
Junio C Hamano writes: > The need to explain better with longer description will reduce the > likelyhood that the feature is understood and correctly used. When > you can write "1-2,4-", why accept "1-4 !3" and force yourself to > explain to people why that is different from "!3 1-4"? By the wa

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-05-06 Thread Junio C Hamano
Ilya Bobyr writes: > Allow better control of the set of tests that will be executed for a > single test suite. Mostly useful while debugging or developing as it > allows to focus on a specific test. > > Signed-off-by: Ilya Bobyr > --- > A number of minor changes according to the review comments

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-04-30 Thread Junio C Hamano
Ilya Bobyr writes: >> The above two illustrate the reason rather well why I said it would >> be better to avoid negation because it would complicate the mental >> model the user needs to form when using the feature. > > I think that you do not have to use it if you do not need it. > It adds some

[PATCH 3/3] test-lib: '--run' to run only specific tests

2014-04-30 Thread Ilya Bobyr
Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test. Signed-off-by: Ilya Bobyr --- A number of minor changes according to the review comments. t/README | 81 ++

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-04-30 Thread Ilya Bobyr
On 4/23/2014 12:51 PM, Eric Sunshine wrote: > On Tue, Apr 22, 2014 at 4:19 AM, Ilya Bobyr wrote: >> Allow better control of the set of tests that will be executed for a >> single test suite. Mostly useful while debugging or developing as it >> allows to focus on a specific test. >> >> Signed-off-

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-04-30 Thread Ilya Bobyr
On 4/23/2014 11:40 AM, Junio C Hamano wrote: > Ilya Bobyr writes: > >> @@ -187,10 +192,70 @@ and either can match the "t[0-9]{4}" part to skip the >> whole >> test, or t[0-9]{4} followed by ".$number" to say which >> particular test to skip. >> >> -Note that some tests in the existing test su

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-04-23 Thread Eric Sunshine
On Tue, Apr 22, 2014 at 4:19 AM, Ilya Bobyr wrote: > Allow better control of the set of tests that will be executed for a > single test suite. Mostly useful while debugging or developing as it > allows to focus on a specific test. > > Signed-off-by: Ilya Bobyr > --- > diff --git a/t/README b/t/R

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-04-23 Thread Junio C Hamano
Ilya Bobyr writes: > @@ -187,10 +192,70 @@ and either can match the "t[0-9]{4}" part to skip the > whole > test, or t[0-9]{4} followed by ".$number" to say which > particular test to skip. > > -Note that some tests in the existing test suite rely on previous > -test item, so you cannot arbit

[PATCH 3/3] test-lib: '--run' to run only specific tests

2014-04-22 Thread Ilya Bobyr
Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test. Signed-off-by: Ilya Bobyr --- t/README | 73 +++- t/t-basic.sh | 356 +

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-03-31 Thread David Tran
> Junio C Hamano pobox.com> writes: > > > I would have to say that there is already an established pattern to > pick ranges that normal people understand well and it would be silly > to invent another more verbose way to express the same thing. You > tell your Print Dialog which page to print wi

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-03-31 Thread Junio C Hamano
Eric Sunshine writes: > Since the relational operators are fairly self-explanatory, you could > drop the prose explanation, though that might make it too cryptic: > > A number prefixed with '<', '<=', '>', or '>=' matches test > numbers meeting the specified relation. I would have to say

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-03-30 Thread Eric Sunshine
On Fri, Mar 28, 2014 at 3:05 AM, Ilya Bobyr wrote: > On 3/27/2014 8:36 PM, Eric Sunshine wrote: >> On Thu, Mar 27, 2014 at 6:32 AM, Ilya Bobyr wrote: >>> Allow better control of the set of tests that will be executed for a >>> single test suite. Mostly useful while debugging or developing as it

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-03-28 Thread Ilya Bobyr
On 3/27/2014 8:36 PM, Eric Sunshine wrote: > On Thu, Mar 27, 2014 at 6:32 AM, Ilya Bobyr wrote: >> Allow better control of the set of tests that will be executed for a >> single test suite. Mostly useful while debugging or developing as it >> allows to focus on a specific test. >> >> Signed-off-b

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-03-27 Thread Eric Sunshine
On Thu, Mar 27, 2014 at 6:32 AM, Ilya Bobyr wrote: > Allow better control of the set of tests that will be executed for a > single test suite. Mostly useful while debugging or developing as it > allows to focus on a specific test. > > Signed-off-by: Ilya Bobyr > --- > No changes from the previo

[PATCH 3/3] test-lib: '--run' to run only specific tests

2014-03-27 Thread Ilya Bobyr
Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test. Signed-off-by: Ilya Bobyr --- No changes from the previous version. t/README | 65 ++- t/t-ba

[PATCH 3/3] test-lib: '--run' to run only specific tests

2014-03-24 Thread Ilya Bobyr
Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test. Signed-off-by: Ilya Bobyr --- t/README | 65 ++- t/t-basic.sh | 233 ++