Re: [PATCH 3/3] t3600: use helper functions from test-lib-functions

2019-03-03 Thread Junio C Hamano
Rohit Ashiwal writes: > Subject: Re: [PATCH 3/3] t3600: use helper functions from test-lib-functions There are tons of helpers in that lib. > Replace `test -(d|f|e|s)` calls in `t3600-rm.sh`. This one gives more useful information than the patch title. Perhaps Subject: [PATCH 3/3]

[PATCH 3/3] t3600: use helper functions from test-lib-functions

2019-03-03 Thread Rohit Ashiwal
Replace `test -(d|f|e|s)` calls in `t3600-rm.sh`. Previously we were using `test -(d|f|e|s)` to verify the presence of a directory/file, but we already have helper functions, viz, `test_path_is_dir`, `test_path_is_file`, `test_path_is_missing` and `test_file_not_empty` with better functionality.