Re: [PATCH 3/3] submodule: implement `module_clone` as a builtin helper

2015-09-01 Thread Eric Sunshine
On Tue, Sep 1, 2015 at 1:49 PM, Stefan Beller wrote: > took all suggestions except the one below. > >> >> if (strbuf_getcwd(&sb)) >> die_errno(...); >> strbuf_addf(&sb, "/%s, sm_gitdir); >> free(sm_gitdir); >> sm_gitdir = strbuf_detach(&sb, NULL); >> >>> + } >>> + >>>

Re: [PATCH 3/3] submodule: implement `module_clone` as a builtin helper

2015-09-01 Thread Stefan Beller
took all suggestions except the one below. > > if (strbuf_getcwd(&sb)) > die_errno(...); > strbuf_addf(&sb, "/%s, sm_gitdir); > free(sm_gitdir); > sm_gitdir = strbuf_detach(&sb, NULL); > >> + } >> + >> + if (strbuf_getcwd(&sb)) >> + die_errno("unab

Re: [PATCH 3/3] submodule: implement `module_clone` as a builtin helper

2015-08-31 Thread Eric Sunshine
On Mon, Aug 31, 2015 at 3:19 PM, Stefan Beller wrote: > `module_clone` is part of the update command, > which I want to convert to C next. Hmm, place commentary below "---". > Signed-off-by: Stefan Beller > Signed-off-by: Junio C Hamano > --- > diff --git a/builtin/submodule--helper.c b/builti

[PATCH 3/3] submodule: implement `module_clone` as a builtin helper

2015-08-31 Thread Stefan Beller
`module_clone` is part of the update command, which I want to convert to C next. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- builtin/submodule--helper.c | 148 +++- git-submodule.sh| 80 +--- 2 files cha