Re: [PATCH 3/3] sha1: use char type for temporary work buffer

2012-09-12 Thread Yann Droneaud
Le mercredi 12 septembre 2012 à 17:04 -0400, Jeff King a écrit : > > > Wouldn't this break all of the code that is planning to index "W" by > > > 32-bit words (see the definitions of setW in block-sha1/sha1.c)? > > > > > That's not the same "W" ... This part of the code is indeed unclear. > > So

Re: [PATCH 3/3] sha1: use char type for temporary work buffer

2012-09-12 Thread Jeff King
On Wed, Sep 12, 2012 at 10:37:10PM +0200, Yann Droneaud wrote: > > > diff --git a/block-sha1/sha1.h b/block-sha1/sha1.h > > > index b864df6..d29ff6a 100644 > > > --- a/block-sha1/sha1.h > > > +++ b/block-sha1/sha1.h > > > @@ -9,7 +9,7 @@ > > > typedef struct { > > > unsigned long long size; > >

Re: [PATCH 3/3] sha1: use char type for temporary work buffer

2012-09-12 Thread Yann Droneaud
Le mercredi 12 septembre 2012 à 14:38 -0400, Jeff King a écrit : > On Wed, Sep 12, 2012 at 12:30:45PM +0200, Yann Droneaud wrote: > > > The SHA context is holding a temporary buffer for partial block. > > > > This block must 64 bytes long. It is currently described as > > an array of 16 integers.

Re: [PATCH 3/3] sha1: use char type for temporary work buffer

2012-09-12 Thread Yann Droneaud
Le mercredi 12 septembre 2012 à 11:42 -0700, Junio C Hamano a écrit : > Yann Droneaud writes: > > > The SHA context is holding a temporary buffer for partial block. > > > > This block must 64 bytes long. It is currently described as > > an array of 16 integers. > > > > Signed-off-by: Yann Droneau

Re: [PATCH 3/3] sha1: use char type for temporary work buffer

2012-09-12 Thread Junio C Hamano
Yann Droneaud writes: > The SHA context is holding a temporary buffer for partial block. > > This block must 64 bytes long. It is currently described as > an array of 16 integers. > > Signed-off-by: Yann Droneaud > --- As we do not work with 16-bit integers anyway, 16 integers occupy 64 bytes a

Re: [PATCH 3/3] sha1: use char type for temporary work buffer

2012-09-12 Thread Jeff King
On Wed, Sep 12, 2012 at 12:30:45PM +0200, Yann Droneaud wrote: > The SHA context is holding a temporary buffer for partial block. > > This block must 64 bytes long. It is currently described as > an array of 16 integers. > > Signed-off-by: Yann Droneaud > --- > block-sha1/sha1.h | 2 +- > 1 fi

[PATCH 3/3] sha1: use char type for temporary work buffer

2012-09-12 Thread Yann Droneaud
The SHA context is holding a temporary buffer for partial block. This block must 64 bytes long. It is currently described as an array of 16 integers. Signed-off-by: Yann Droneaud --- block-sha1/sha1.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block-sha1/sha1.h b/block-