On Fri, Feb 17, 2017 at 06:41:32PM -0500, Kyle Meyer wrote:
> Junio C Hamano writes:
>
> [...]
>
> > Do we even want these "internal" delete_ref() invocations to be
> > logged in HEAD's reflog? I understand that this is inside the
> > implementation of renaming an old ref to a new ref, and ref
Kyle Meyer writes:
> Junio C Hamano writes:
>
> [...]
>
>> Do we even want these "internal" delete_ref() invocations to be
>> logged in HEAD's reflog? I understand that this is inside the
>> implementation of renaming an old ref to a new ref, and reflog
>> message given to delete_ref() would ma
Jeff King writes:
> On Fri, Feb 17, 2017 at 02:43:50PM -0500, Jeff King wrote:
>
>> Yes. I think the options are basically (in order of decreasing
>> preference in my opinion):
>>
>> 1. Log a rename entry (same sha1, but note the rename in the free-form
>> text).
>>
>> 2. Log a delete
Junio C Hamano writes:
[...]
> Do we even want these "internal" delete_ref() invocations to be
> logged in HEAD's reflog? I understand that this is inside the
> implementation of renaming an old ref to a new ref, and reflog
> message given to delete_ref() would matter only if the HEAD happens
>
Jeff King writes:
> Thinking on it more, we probably _do_ want two entries. Because the
> operations are not atomic, it's possible that we may end up in a
> half-way state after the first entry is written. And when debugging such
> a case, I'd much rather see the first half of the operation logge
On Fri, Feb 17, 2017 at 02:43:50PM -0500, Jeff King wrote:
> Yes. I think the options are basically (in order of decreasing
> preference in my opinion):
>
> 1. Log a rename entry (same sha1, but note the rename in the free-form
> text).
>
> 2. Log a delete (sha1 goes to null) followed b
On Fri, Feb 17, 2017 at 09:50:54AM -0800, Junio C Hamano wrote:
> > I see we actually already have a "logmsg" parameter. It already says
> > "Branch: renamed %s to %s". Could we just reuse that? I know that this
> > step is technically just the deletion, but I think it more accurately
> > describe
Jeff King writes:
> On Thu, Feb 16, 2017 at 10:58:00PM -0500, Kyle Meyer wrote:
>
>> When the current branch is renamed, the deletion of the old ref is
>> recorded in HEAD's log with an empty message. Now that delete_refs()
>> accepts a reflog message, provide a more descriptive message. This
>
On Thu, Feb 16, 2017 at 10:58:00PM -0500, Kyle Meyer wrote:
> When the current branch is renamed, the deletion of the old ref is
> recorded in HEAD's log with an empty message. Now that delete_refs()
> accepts a reflog message, provide a more descriptive message. This
> message will not be inclu
When the current branch is renamed, the deletion of the old ref is
recorded in HEAD's log with an empty message. Now that delete_refs()
accepts a reflog message, provide a more descriptive message. This
message will not be included in the reflog of the renamed branch, but
its log already covers t
10 matches
Mail list logo
