Re: [PATCH 3/3] execv_dashed_external: wait for child on signal death

2017-01-07 Thread Duy Nguyen
On Sat, Jan 7, 2017 at 8:22 AM, Jeff King wrote: > When you hit ^C to interrupt a git command going to a pager, > this usually leaves the pager running. But when a dashed > external is in use, the pager ends up in a funny state and > quits (but only after eating one more character from the > termi

Re: [PATCH 3/3] execv_dashed_external: wait for child on signal death

2017-01-06 Thread Jeff King
On Sat, Jan 07, 2017 at 08:28:22AM +0100, Johannes Sixt wrote: > > But when you have a dashed external (or an alias pointing to > > a builtin, which will re-exec git for the builtin), there's > > an extra process in the mix. For instance, running: > > > > git -c alias.l=log log > > This should

Re: [PATCH 3/3] execv_dashed_external: wait for child on signal death

2017-01-06 Thread Johannes Sixt
Am 07.01.2017 um 02:22 schrieb Jeff King: When you hit ^C to interrupt a git command going to a pager, this usually leaves the pager running. But when a dashed external is in use, the pager ends up in a funny state and quits (but only after eating one more character from the terminal!). This fixe

[PATCH 3/3] execv_dashed_external: wait for child on signal death

2017-01-06 Thread Jeff King
When you hit ^C to interrupt a git command going to a pager, this usually leaves the pager running. But when a dashed external is in use, the pager ends up in a funny state and quits (but only after eating one more character from the terminal!). This fixes it. Explaining the reason will require a