Re: [PATCH 3/3] commit: give a hint when a commit message has been abandoned

2012-07-23 Thread Junio C Hamano
Jeff King writes: > On Mon, Jul 23, 2012 at 02:35:01PM -0700, Junio C Hamano wrote: > ... >> I also wondered if something like the following might be useful, but >> it probably falls into the "water under the bridge" category. >> >> builtin/commit.c | 5 + >> 1 file changed, 5 insertions(+)

Re: [PATCH 3/3] commit: give a hint when a commit message has been abandoned

2012-07-23 Thread Jeff King
On Mon, Jul 23, 2012 at 02:35:01PM -0700, Junio C Hamano wrote: > > +FILES > > +- > > + > > +`$GIT_DIR/COMMIT_EDITMSG`:: > > + This file contains the commit message of a commit in progress. > > + If `git-commit` exits due to an error before creating a commit, > > + any commit message tha

Re: [PATCH 3/3] commit: give a hint when a commit message has been abandoned

2012-07-23 Thread Junio C Hamano
Jeff King writes: > Here's a documentation patch. > > -- >8 -- > Subject: [PATCH] commit: document the temporary commit message file > > We do not document COMMIT_EDITMSG at all, but users may want > to know about it for two reasons: > > 1. They may want to tell their editor to configure itself

Re: [PATCH 3/3] commit: give a hint when a commit message has been abandoned

2012-07-23 Thread Jeff King
On Mon, Jul 23, 2012 at 02:00:19PM -0700, Junio C Hamano wrote: > >> Liberal use of atexit() for something like this makes me cringe > >> somewhat. > > > > I don't like it either, but there's not really a better way. The die() > > that Ramana triggered in the initial report is deep inside the iden

Re: [PATCH 3/3] commit: give a hint when a commit message has been abandoned

2012-07-23 Thread Junio C Hamano
Jeff King writes: > On Mon, Jul 23, 2012 at 01:49:55PM -0700, Junio C Hamano wrote: > >> Jeff King writes: >> >> > If we launch an editor for the user to create a commit >> > message, they may put significant work into doing so. >> > Typically we try to check common mistakes that could cause >>

Re: [PATCH 3/3] commit: give a hint when a commit message has been abandoned

2012-07-23 Thread Jeff King
On Mon, Jul 23, 2012 at 01:49:55PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > If we launch an editor for the user to create a commit > > message, they may put significant work into doing so. > > Typically we try to check common mistakes that could cause > > the commit to fail early,

Re: [PATCH 3/3] commit: give a hint when a commit message has been abandoned

2012-07-23 Thread Junio C Hamano
Jeff King writes: > If we launch an editor for the user to create a commit > message, they may put significant work into doing so. > Typically we try to check common mistakes that could cause > the commit to fail early, so that we die before the user > goes to the trouble. > > We may still experi

[PATCH 3/3] commit: give a hint when a commit message has been abandoned

2012-07-23 Thread Jeff King
If we launch an editor for the user to create a commit message, they may put significant work into doing so. Typically we try to check common mistakes that could cause the commit to fail early, so that we die before the user goes to the trouble. We may still experience some errors afterwards, thou