Re: [PATCH 3/3] builtin/help.c: fix memory leak

2015-03-10 Thread Junio C Hamano
Stefan Beller writes: >> Hmph, does this memory belong to us, or are we peeking into the >> cached data in the config cache layer? > > So alias_lookup(..) is a wrapper around git_config_string essentially > (some more git_config_functions are involved, but we eventually reach > git_config_string

Re: [PATCH 3/3] builtin/help.c: fix memory leak

2015-03-10 Thread Stefan Beller
On Tue, Mar 10, 2015 at 3:43 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Signed-off-by: Stefan Beller >> --- >> builtin/help.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/builtin/help.c b/builtin/help.c >> index 6133fe4..a1f5a0a 100644 >> --- a/built

Re: [PATCH 3/3] builtin/help.c: fix memory leak

2015-03-10 Thread Junio C Hamano
Stefan Beller writes: > Signed-off-by: Stefan Beller > --- > builtin/help.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/builtin/help.c b/builtin/help.c > index 6133fe4..a1f5a0a 100644 > --- a/builtin/help.c > +++ b/builtin/help.c > @@ -456,7 +456,7 @@ static void

[PATCH 3/3] builtin/help.c: fix memory leak

2015-03-09 Thread Stefan Beller
Signed-off-by: Stefan Beller --- builtin/help.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/builtin/help.c b/builtin/help.c index 6133fe4..a1f5a0a 100644 --- a/builtin/help.c +++ b/builtin/help.c @@ -456,7 +456,7 @@ static void list_common_guides_help(void) int cmd_help