Re: [PATCH 3/3] Make sure refs/rewritten/ is per-worktree

2019-03-07 Thread Duy Nguyen
On Thu, Mar 7, 2019 at 9:45 PM Phillip Wood wrote: > > [1] note that ref listing still works sometimes. For example, if you > > have .git/worktrees/foo/refs/rewritten/bar AND the directory > > .git/worktrees/refs/rewritten, > > should that be .git/refs/rewritten? (and below) Yes. -- Du

Re: [PATCH 3/3] Make sure refs/rewritten/ is per-worktree

2019-03-07 Thread Phillip Wood
Hi Duy Thanks for working on this I've had a quick look through and they seem to make sense to me although I've not really looked at the refs code before. On 07/03/2019 12:29, Nguyễn Thái Ngọc Duy wrote: a9be29c981 (sequencer: make refs generated by the `label` command worktree-local, 2018-04

[PATCH 3/3] Make sure refs/rewritten/ is per-worktree

2019-03-07 Thread Nguyễn Thái Ngọc Duy
a9be29c981 (sequencer: make refs generated by the `label` command worktree-local, 2018-04-25) adds refs/rewritten/ as per-worktree reference space. Unfortunately (my bad) there are a couple places that need update to make sure it's really per-worktree. - add_per_worktree_entries_to_dir() is updat