Re: [PATCH 3/2] t5309: mark delta-cycle failover tests as passing

2014-09-02 Thread Junio C Hamano
Jeff King writes: > We used to do that because the only way to correctly resolve them was by > introducing a duplicate base object, and we did not allow that. Patch 2 > from my series loosened this, which makes index-pack work, but not > necessarily the rest of git. And since index-pack is the ga

Re: [PATCH 3/2] t5309: mark delta-cycle failover tests as passing

2014-08-31 Thread Jeff King
On Sat, Aug 30, 2014 at 09:23:11AM -0400, Jeff King wrote: > The implications of this make me slightly nervous, though. In the > --fix-thin case, the resulting pack will have 3 objects: > > - A as a delta on B > - B as a delta on A > - a full copy of either A (or B) provided by --fix-thin >

[PATCH 3/2] t5309: mark delta-cycle failover tests as passing

2014-08-30 Thread Jeff King
t5309 checks that we detect and fail when there is a cycle of deltas (i.e., A is a delta on B, which is a delta on A). It also checks the cases where we have such a cycle, but we have an extra copy of the object either in the same pack or in another one. These cases are recoverable, because we can