Re: [PATCH 27/34] sequencer (rebase -i): differentiate between comments and 'noop'

2016-09-02 Thread Johannes Schindelin
Hi Dennis, On Thu, 1 Sep 2016, Dennis Kaarsemaker wrote: > /* >  * Note that ordering matters in this enum. Not only must it match the >  * mapping below, it is also divided into several sections that matter. >  * When adding new commands, make sure you add it in the right section. >  */ > enum t

Re: [PATCH 27/34] sequencer (rebase -i): differentiate between comments and 'noop'

2016-09-01 Thread Dennis Kaarsemaker
On do, 2016-09-01 at 17:32 +0200, Johannes Schindelin wrote: > Hi Dennis, > > On Thu, 1 Sep 2016, Dennis Kaarsemaker wrote: > > > > > On wo, 2016-08-31 at 10:56 +0200, Johannes Schindelin wrote: > > > > > > diff --git a/sequencer.c b/sequencer.c > > > index 51c2f76..4c902e5 100644 > > > --- a/s

Re: [PATCH 27/34] sequencer (rebase -i): differentiate between comments and 'noop'

2016-09-01 Thread Johannes Schindelin
Hi Dennis, On Thu, 1 Sep 2016, Dennis Kaarsemaker wrote: > On wo, 2016-08-31 at 10:56 +0200, Johannes Schindelin wrote: > > diff --git a/sequencer.c b/sequencer.c > > index 51c2f76..4c902e5 100644 > > --- a/sequencer.c > > +++ b/sequencer.c > > @@ -763,7 +763,8 @@ enum todo_command { > >

Re: [PATCH 27/34] sequencer (rebase -i): differentiate between comments and 'noop'

2016-09-01 Thread Dennis Kaarsemaker
On wo, 2016-08-31 at 10:56 +0200, Johannes Schindelin wrote: > diff --git a/sequencer.c b/sequencer.c > index 51c2f76..4c902e5 100644 > --- a/sequencer.c > +++ b/sequencer.c > @@ -763,7 +763,8 @@ enum todo_command { > TODO_SQUASH, > TODO_EXEC, > TODO_NOOP, > -   TODO_DRO

[PATCH 27/34] sequencer (rebase -i): differentiate between comments and 'noop'

2016-08-31 Thread Johannes Schindelin
In the upcoming patch, we will support rebase -i's progress reporting. The progress skips comments but counts 'noop's. Signed-off-by: Johannes Schindelin --- sequencer.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sequencer.c b/sequencer.c index 51c2f76..4c