Re: [PATCH 25/41] builtin/receive-pack: avoid hard-coded constants for push certs

2018-04-24 Thread Martin Ågren
On 25 April 2018 at 04:00, brian m. carlson wrote: > On Tue, Apr 24, 2018 at 11:58:17AM +0200, Martin Ågren wrote: >> On 24 April 2018 at 01:39, brian m. carlson >> > diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c >> > index c4272fbc96..5f35596c14 100644 >> > --- a/builtin/receive-pa

Re: [PATCH 25/41] builtin/receive-pack: avoid hard-coded constants for push certs

2018-04-24 Thread brian m. carlson
On Tue, Apr 24, 2018 at 11:58:17AM +0200, Martin Ågren wrote: > On 24 April 2018 at 01:39, brian m. carlson > > diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c > > index c4272fbc96..5f35596c14 100644 > > --- a/builtin/receive-pack.c > > +++ b/builtin/receive-pack.c > > @@ -454,21 +454,

Re: [PATCH 25/41] builtin/receive-pack: avoid hard-coded constants for push certs

2018-04-24 Thread Martin Ågren
On 24 April 2018 at 01:39, brian m. carlson wrote: > Use the GIT_SHA1_RAWSZ and GIT_SHA1_HEXSZ macros instead of hard-coding > the constants 20 and 40. Switch one use of 20 with a format specifier > for a hex value to use the hex constant instead, as the original appears > to have been a typo. >

[PATCH 25/41] builtin/receive-pack: avoid hard-coded constants for push certs

2018-04-23 Thread brian m. carlson
Use the GIT_SHA1_RAWSZ and GIT_SHA1_HEXSZ macros instead of hard-coding the constants 20 and 40. Switch one use of 20 with a format specifier for a hex value to use the hex constant instead, as the original appears to have been a typo. At this point, avoid converting the hard-coded use of SHA-1 t