Re: [PATCH 25/27] attr: store attribute stacks in hashmap

2017-01-23 Thread Brandon Williams
On 01/18, Brandon Williams wrote: > On 01/13, Junio C Hamano wrote: > > Brandon Williams writes: > > > > > The last big hurdle towards a thread-safe API for the attribute system > > > is the reliance on a global attribute stack that is modified during each > > > call into the attribute system. >

Re: [PATCH 25/27] attr: store attribute stacks in hashmap

2017-01-18 Thread Stefan Beller
On Wed, Jan 18, 2017 at 12:39 PM, Stefan Beller wrote: > On Thu, Jan 12, 2017 at 3:53 PM, Brandon Williams wrote: >> -static void prepare_attr_stack(const char *path, int dirlen) >> +/* >> + * This funciton should only be called from 'get_attr_stack()', which >> already > > "function" > >> +

Re: [PATCH 25/27] attr: store attribute stacks in hashmap

2017-01-18 Thread Brandon Williams
On 01/18, Stefan Beller wrote: > On Thu, Jan 12, 2017 at 3:53 PM, Brandon Williams wrote: > > -static void prepare_attr_stack(const char *path, int dirlen) > > +/* > > + * This funciton should only be called from 'get_attr_stack()', which > > already > > "function" > > > + /* syst

Re: [PATCH 25/27] attr: store attribute stacks in hashmap

2017-01-18 Thread Stefan Beller
On Thu, Jan 12, 2017 at 3:53 PM, Brandon Williams wrote: > -static void prepare_attr_stack(const char *path, int dirlen) > +/* > + * This funciton should only be called from 'get_attr_stack()', which already "function" > + /* system-wide frame */ > + if (git_attr_syst

Re: [PATCH 25/27] attr: store attribute stacks in hashmap

2017-01-18 Thread Brandon Williams
On 01/13, Junio C Hamano wrote: > Brandon Williams writes: > > > The last big hurdle towards a thread-safe API for the attribute system > > is the reliance on a global attribute stack that is modified during each > > call into the attribute system. > > > > This patch removes this global stack and

Re: [PATCH 25/27] attr: store attribute stacks in hashmap

2017-01-13 Thread Junio C Hamano
Brandon Williams writes: > The last big hurdle towards a thread-safe API for the attribute system > is the reliance on a global attribute stack that is modified during each > call into the attribute system. > > This patch removes this global stack and instead a stack is retrieved or > constructed

[PATCH 25/27] attr: store attribute stacks in hashmap

2017-01-12 Thread Brandon Williams
The last big hurdle towards a thread-safe API for the attribute system is the reliance on a global attribute stack that is modified during each call into the attribute system. This patch removes this global stack and instead a stack is retrieved or constructed locally. Since each of these stacks