Re: [PATCH 25/25] diff: document the new --color-moved setting

2017-06-30 Thread Stefan Beller
On Fri, Jun 30, 2017 at 1:31 PM, Simon Ruderich wrote: > On Fri, Jun 30, 2017 at 09:04:50AM -0700, Stefan Beller wrote: >> [snip] >> >> However >> >> context >> + moved line, block A or B >> + moved line, block A or B >> context >> >> is omitted, because the number of lines >> here is

Re: [PATCH 25/25] diff: document the new --color-moved setting

2017-06-30 Thread Simon Ruderich
On Fri, Jun 30, 2017 at 09:04:50AM -0700, Stefan Beller wrote: > [snip] > > However > > context > + moved line, block A or B > + moved line, block A or B > context > > is omitted, because the number of lines > here is fewer than 3 ignoring the block > type. > > Maybe > > If there are

Re: [PATCH 25/25] diff: document the new --color-moved setting

2017-06-30 Thread Stefan Beller
On Fri, Jun 30, 2017 at 12:26 AM, Simon Ruderich wrote: > On Thu, Jun 29, 2017 at 05:07:10PM -0700, Stefan Beller wrote: >> + Small blocks of 3 moved lines or fewer are skipped. > > If I read the commit messages correctly, this "skipping" process > applies to the move detection in general for

Re: [PATCH 25/25] diff: document the new --color-moved setting

2017-06-30 Thread Simon Ruderich
On Thu, Jun 29, 2017 at 05:07:10PM -0700, Stefan Beller wrote: > + Small blocks of 3 moved lines or fewer are skipped. If I read the commit messages correctly, this "skipping" process applies to the move detection in general for those smaller blocks and therefore doesn't mean a malicious move

[PATCH 25/25] diff: document the new --color-moved setting

2017-06-29 Thread Stefan Beller
Signed-off-by: Stefan Beller --- Documentation/config.txt | 15 +-- Documentation/diff-options.txt | 34 ++ 2 files changed, 47 insertions(+), 2 deletions(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 06898a7498..74382