Re: [PATCH 24/31] archive-tar: make hash size independent

2019-02-12 Thread brian m. carlson
On Tue, Feb 12, 2019 at 06:33:39PM +0100, René Scharfe wrote: > Am 12.02.2019 um 08:20 schrieb René Scharfe: > > That command currently prints the pax comment in tar archives if it > > looks like a SHA1 hash based on its length. It should continue to do > > so, and _also_ show longer hashes. Your

Re: [PATCH 24/31] archive-tar: make hash size independent

2019-02-12 Thread René Scharfe
Am 12.02.2019 um 08:20 schrieb René Scharfe: > That command currently prints the pax comment in tar archives if it > looks like a SHA1 hash based on its length. It should continue to do > so, and _also_ show longer hashes. Your change makes it _only_ show > those longer hashes. > > So it could ch

Re: [PATCH 24/31] archive-tar: make hash size independent

2019-02-11 Thread René Scharfe
Am 12.02.2019 um 02:22 schrieb brian m. carlson: > diff --git a/builtin/get-tar-commit-id.c b/builtin/get-tar-commit-id.c > index 2706fcfaf2..2760549e91 100644 > --- a/builtin/get-tar-commit-id.c > +++ b/builtin/get-tar-commit-id.c > @@ -5,6 +5,7 @@ > #include "commit.h" > #include "tar.h" > #in

[PATCH 24/31] archive-tar: make hash size independent

2019-02-11 Thread brian m. carlson
Make the tar generation code hash size independent by using the_hash_algo. Make the tar parsing code compute the header value based on the hash algorithm in use. Update a variable name and switch to hash_to_hex. Signed-off-by: brian m. carlson --- archive-tar.c | 7 --- built