Re: [PATCH 22/26] diff.c: color moved lines differently

2017-06-20 Thread Stefan Beller
On Tue, Jun 20, 2017 at 1:13 PM, Jonathan Tan wrote: > I just glanced through this file, because it seems similar to the > versions I have previously reviewed. Yes, this has not changed much. The thing that took so long were patches 1-20 to do. In these later patches (22) the UX was changed sligh

Re: [PATCH 22/26] diff.c: color moved lines differently

2017-06-20 Thread Jonathan Tan
I just glanced through this file, because it seems similar to the versions I have previously reviewed. I'll skip patches 23 onwards in this round of review because (i) I would be happy if just patches 1-22 were included in the tree and (ii) those patches might end up changing anyway because of rev

[PATCH 22/26] diff.c: color moved lines differently

2017-06-19 Thread Stefan Beller
When a patch consists mostly of moving blocks of code around, it can be quite tedious to ensure that the blocks are moved verbatim, and not undesirably modified in the move. To that end, color blocks that are moved within the same patch differently. For example (OM, del, add, and NM are different c