Re: [PATCH 20/33] combine-diff: convert find_paths_* to struct object_id

2017-06-01 Thread Junio C Hamano
Stefan Beller writes: > On Tue, May 30, 2017 at 10:30 AM, Brandon Williams wrote: >> Convert find_paths_generic and find_paths_multitree to use struct >> object_id. >> >> > > double empty line? Is it because sed -e 's/^Change-ID:.*//' insead of sed -e '/^Change-ID:.*/d' is u

Re: [PATCH 20/33] combine-diff: convert find_paths_* to struct object_id

2017-05-31 Thread Stefan Beller
On Tue, May 30, 2017 at 10:30 AM, Brandon Williams wrote: > Convert find_paths_generic and find_paths_multitree to use struct > object_id. > > double empty line? Unlike some other prior patches, it is nice to see a commit message here. :) Code of the patches up to here looks good.

[PATCH 20/33] combine-diff: convert find_paths_* to struct object_id

2017-05-30 Thread Brandon Williams
Convert find_paths_generic and find_paths_multitree to use struct object_id. Signed-off-by: Brandon Williams --- combine-diff.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/combine-diff.c b/combine-diff.c index 84981df75..c82364510 100644 --- a/combine-diff.c