Re: [PATCH 2/8] entry: factor out unlink_entry function

2018-12-20 Thread Thomas Gummerer
On 12/10, Duy Nguyen wrote: > On Sun, Dec 9, 2018 at 9:05 PM Thomas Gummerer wrote: > > > > Factor out the 'unlink_entry()' function from unpack-trees.c to > > entry.c. It will be used in other places as well in subsequent > > steps. > > > > As it's no longer a static function, also move the docu

Re: [PATCH 2/8] entry: factor out unlink_entry function

2018-12-10 Thread Junio C Hamano
Duy Nguyen writes: > I wonder if we should move the 'removal' variable in symlinks to > 'struct checkout' to reduce another global variable. But I guess > that's the problem for another day. It's not the focus of this series. Before any such move, I think it is important to notice that the thing

Re: [PATCH 2/8] entry: factor out unlink_entry function

2018-12-10 Thread Duy Nguyen
On Mon, Dec 10, 2018 at 6:23 PM Elijah Newren wrote: > > I wonder if we should move the 'removal' variable in symlinks to > > 'struct checkout' to reduce another global variable. But I guess > > that's the problem for another day. It's not the focus of this series. > > "move the 'removal' variable

Re: [PATCH 2/8] entry: factor out unlink_entry function

2018-12-10 Thread Elijah Newren
On Mon, Dec 10, 2018 at 7:50 AM Duy Nguyen wrote: > > On Sun, Dec 9, 2018 at 9:05 PM Thomas Gummerer wrote: > > > > Factor out the 'unlink_entry()' function from unpack-trees.c to > > entry.c. It will be used in other places as well in subsequent > > steps. > > > > As it's no longer a static fun

Re: [PATCH 2/8] entry: factor out unlink_entry function

2018-12-10 Thread Duy Nguyen
On Sun, Dec 9, 2018 at 9:05 PM Thomas Gummerer wrote: > > Factor out the 'unlink_entry()' function from unpack-trees.c to > entry.c. It will be used in other places as well in subsequent > steps. > > As it's no longer a static function, also move the documentation to > the header file to make it

[PATCH 2/8] entry: factor out unlink_entry function

2018-12-09 Thread Thomas Gummerer
Factor out the 'unlink_entry()' function from unpack-trees.c to entry.c. It will be used in other places as well in subsequent steps. As it's no longer a static function, also move the documentation to the header file to make it more discoverable. Signed-off-by: Thomas Gummerer --- cache.h