Re: Rename detection within in files WAS: [PATCH 2/6] t7408: merge short tests, factor out testing method

2016-08-07 Thread René Scharfe
Am 06.08.2016 um 01:26 schrieb Stefan Beller: When moving code around, we usually get large chunks of text. If the contributor is not 100% trustworthy, we need to review all the code without much intelectual joy. Essentially the reviewer is just making sure the parts of the text are the same. I'

Rename detection within in files WAS: [PATCH 2/6] t7408: merge short tests, factor out testing method

2016-08-06 Thread Stefan Beller
When moving code around, we usually get large chunks of text. If the contributor is not 100% trustworthy, we need to review all the code without much intelectual joy. Essentially the reviewer is just making sure the parts of the text are the same. I'd like to propose a new addition to the diff for

Re: [PATCH 2/6] t7408: merge short tests, factor out testing method

2016-08-06 Thread Stefan Beller
On Fri, Aug 5, 2016 at 1:45 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Tests consisting of one line each can be consolidated to have fewer tests >> to run as well as fewer lines of code. >> >> When having just a few git commands, do not create a new shell but >> use the -C flag in Git

Re: [PATCH 2/6] t7408: merge short tests, factor out testing method

2016-08-06 Thread Junio C Hamano
Stefan Beller writes: >>> -test_expect_success 'that reference gets used with add' ' >>> - ( >>> - cd super/sub && >>> - echo "0 objects, 0 kilobytes" > expected && >>> - git count-objects > current && >>> - diff expected current > > This is whe

Re: [PATCH 2/6] t7408: merge short tests, factor out testing method

2016-08-05 Thread Junio C Hamano
Stefan Beller writes: > Tests consisting of one line each can be consolidated to have fewer tests > to run as well as fewer lines of code. > > When having just a few git commands, do not create a new shell but > use the -C flag in Git to execute in the correct directory. Good motivations. > Sig

[PATCH 2/6] t7408: merge short tests, factor out testing method

2016-08-04 Thread Stefan Beller
Tests consisting of one line each can be consolidated to have fewer tests to run as well as fewer lines of code. When having just a few git commands, do not create a new shell but use the -C flag in Git to execute in the correct directory. Signed-off-by: Stefan Beller --- t/t7408-submodule-refe