Re: [PATCH 2/6] t5538: fix default http port

2014-02-10 Thread Jeff King
On Mon, Feb 10, 2014 at 10:23:53AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > Here it is as a Real Patch™. I just based it on master, so it can > > replace your 5537/5538 fix in your series. > > Thanks, looks good. Will put this at the bottom and rebuild the > nd/http-fetch-shallow

Re: [PATCH 2/6] t5538: fix default http port

2014-02-10 Thread Jeff King
On Mon, Feb 10, 2014 at 02:15:24PM -0500, Jeff King wrote: > Thanks. It might be worth squashing in the patch below (or sticking it > on top), to cover git-daemon as well. Patch would probably be easier to read if I actually included it... -- >8 -- Subject: [PATCH] tests: auto-set git-daemon por

Re: [PATCH 2/6] t5538: fix default http port

2014-02-10 Thread Junio C Hamano
Jeff King writes: > Here it is as a Real Patch™. I just based it on master, so it can > replace your 5537/5538 fix in your series. Thanks, looks good. Will put this at the bottom and rebuild the nd/http-fetch-shallow-fix series on top. > 1. Is there anybody who has apache installed who would

Re: [PATCH 2/6] t5538: fix default http port

2014-02-10 Thread Jeff King
On Sat, Feb 08, 2014 at 02:36:11PM +0700, Duy Nguyen wrote: > > Thinking on this more, I wonder if we should just do something like > > this: > [...] > Yes! Here it is as a Real Patch™. I just based it on master, so it can replace your 5537/5538 fix in your series. > Next stop, attempt to start

Re: [PATCH 2/6] t5538: fix default http port

2014-02-07 Thread Duy Nguyen
On Sat, Feb 8, 2014 at 6:47 AM, Jeff King wrote: > Thinking on this more, I wonder if we should just do something like > this: > > diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh > index bfdff2a..c82b4ee 100644 > --- a/t/lib-httpd.sh > +++ b/t/lib-httpd.sh > @@ -64,7 +64,9 @@ case $(uname) in > esac

Re: [PATCH 2/6] t5538: fix default http port

2014-02-07 Thread Jeff King
On Thu, Feb 06, 2014 at 02:35:33PM -0500, Jeff King wrote: > On Thu, Feb 06, 2014 at 10:10:35PM +0700, Nguyễn Thái Ngọc Duy wrote: > > > Originally I had t5537 use port 5536 and 5538 use port 5537(!). Then > > Jeff found my fault so I changed port in t5537 from 5536 to 5537 in > > 3b32a7c (t5537:

Re: [PATCH 2/6] t5538: fix default http port

2014-02-06 Thread Jeff King
On Thu, Feb 06, 2014 at 10:10:35PM +0700, Nguyễn Thái Ngọc Duy wrote: > Originally I had t5537 use port 5536 and 5538 use port 5537(!). Then > Jeff found my fault so I changed port in t5537 from 5536 to 5537 in > 3b32a7c (t5537: fix incorrect expectation in test case 10 - > 2014-01-08). Which make

[PATCH 2/6] t5538: fix default http port

2014-02-06 Thread Nguyễn Thái Ngọc Duy
Originally I had t5537 use port 5536 and 5538 use port 5537(!). Then Jeff found my fault so I changed port in t5537 from 5536 to 5537 in 3b32a7c (t5537: fix incorrect expectation in test case 10 - 2014-01-08). Which makes it worse because now both t5537 and t5538 both use the same port. Fix it. Si