Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

2018-05-02 Thread Junio C Hamano
Johannes Schindelin writes: >> As discussed in this thread, tests that use t/helper/ executables >> that try to trickle BUG() codepath to ensure that these "should >> never happen" conditions are caught do need to deal with it. If >> dumping core is undesirable, tweaking BUG() implementation so

Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

2018-05-02 Thread Johannes Schindelin
Hi, On Wed, 2 May 2018, Junio C Hamano wrote: > Duy Nguyen writes: > > > On Mon, Apr 30, 2018 at 12:17 AM, Johannes Schindelin > > wrote: > >> t1406 specifically verifies that certain code paths fail with a BUG: ... > >> message. > >> > >> In the upcoming commit, we will convert that message t

Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

2018-05-01 Thread Junio C Hamano
Duy Nguyen writes: > On Mon, Apr 30, 2018 at 12:17 AM, Johannes Schindelin > wrote: >> t1406 specifically verifies that certain code paths fail with a BUG: ... >> message. >> >> In the upcoming commit, we will convert that message to be generated via >> BUG() instead of die("BUG: ..."), which im

Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

2018-05-01 Thread Duy Nguyen
On Mon, Apr 30, 2018 at 12:17 AM, Johannes Schindelin wrote: > t1406 specifically verifies that certain code paths fail with a BUG: ... > message. > > In the upcoming commit, we will convert that message to be generated via > BUG() instead of die("BUG: ..."), which implies SIGABRT instead of a > r

Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

2018-05-01 Thread Duy Nguyen
On Tue, May 1, 2018 at 1:04 PM, Johannes Schindelin wrote: >> If SIGABRT occurs as a result of BUG(), and we know that this happens for >> certain cases, it means we have an unfixed bug. > > Not in this case: The code in question is in > https://github.com/git/git/blob/v2.17.0/t/helper/test-ref-st

Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

2018-05-01 Thread Johannes Schindelin
Hi Hannes, On Mon, 30 Apr 2018, Johannes Sixt wrote: > Am 30.04.2018 um 00:17 schrieb Johannes Schindelin: > > t1406 specifically verifies that certain code paths fail with a BUG: ... > > message. > > > > In the upcoming commit, we will convert that message to be generated via > > BUG() instead

Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

2018-04-30 Thread Johannes Sixt
Am 30.04.2018 um 00:17 schrieb Johannes Schindelin: t1406 specifically verifies that certain code paths fail with a BUG: ... message. In the upcoming commit, we will convert that message to be generated via BUG() instead of die("BUG: ..."), which implies SIGABRT instead of a regular exit code.

[PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

2018-04-29 Thread Johannes Schindelin
t1406 specifically verifies that certain code paths fail with a BUG: ... message. In the upcoming commit, we will convert that message to be generated via BUG() instead of die("BUG: ..."), which implies SIGABRT instead of a regular exit code. Signed-off-by: Johannes Schindelin --- t/t1406-submo