Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

2013-04-30 Thread Junio C Hamano
Ramsay Jones writes: > However, I'm always a little wary when I hear someone say "this may be > useful to others in the future, so lets do X to make it easier ...". > I have noticed that, much more often than not, that future user never > does materialise ... ;-) I do not think you are reading t

Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

2013-04-29 Thread Ramsay Jones
Junio C Hamano wrote: > Ramsay Jones writes: > >> On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should >> it be static?" warning. The MinGW and MSVC builds do not see the >> declaration of this function, within git-compat-util.h, due to it's >> placement within an preprocessor cond

Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

2013-04-29 Thread Ramsay Jones
Torsten Bögershausen wrote: > On 2013-04-27 20.42, Ramsay Jones wrote: >> >> On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should >> it be static?" warning. The MinGW and MSVC builds do not see the >> declaration of this function, within git-compat-util.h, due to it's >> placement wi

Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

2013-04-28 Thread Junio C Hamano
Ramsay Jones writes: > On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should > it be static?" warning. The MinGW and MSVC builds do not see the > declaration of this function, within git-compat-util.h, due to it's > placement within an preprocessor conditional. (So, one solution wou

Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

2013-04-28 Thread Torsten Bögershausen
On 2013-04-28 08.02, Torsten Bögershausen wrote: > On 2013-04-27 20.42, Ramsay Jones wrote: >> >> On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should >> it be static?" warning. The MinGW and MSVC builds do not see the >> declaration of this function, within git-compat-util.h, due to

Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

2013-04-27 Thread Torsten Bögershausen
On 2013-04-27 20.42, Ramsay Jones wrote: > > On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should > it be static?" warning. The MinGW and MSVC builds do not see the > declaration of this function, within git-compat-util.h, due to it's > placement within an preprocessor conditional.

Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

2013-04-27 Thread Eric Sunshine
On Sat, Apr 27, 2013 at 2:42 PM, Ramsay Jones wrote: > > On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should > it be static?" warning. The MinGW and MSVC builds do not see the > declaration of this function, within git-compat-util.h, due to it's s/it's/its/ > placement within an

[PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

2013-04-27 Thread Ramsay Jones
On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should it be static?" warning. The MinGW and MSVC builds do not see the declaration of this function, within git-compat-util.h, due to it's placement within an preprocessor conditional. (So, one solution would be to simply move the decla