Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path

2017-12-21 Thread Junio C Hamano
Alex Vandiver writes: >> But I am not sure if this is a right direction to go in. If a .C >> user of fsmonitor needs (does not need) things from dir.h, that file >> can (does not need to) include dir.h itself. > > Hm; I was patterning based on existing .h files, which don't seem shy > about pull

Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path

2017-12-20 Thread Alex Vandiver
On Tue, 19 Dec 2017, Junio C Hamano wrote: > Alex Vandiver writes: > > > Subject: Re: [PATCH 2/6] fsmonitor: Add dir.h include, for > > untracked_cache_invalidate_path > > Perhaps > > "Subject: fsmonitor.h: include dir.h" Certainly more concise.

Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path

2017-12-19 Thread Junio C Hamano
Alex Vandiver writes: > Subject: Re: [PATCH 2/6] fsmonitor: Add dir.h include, for > untracked_cache_invalidate_path Perhaps "Subject: fsmonitor.h: include dir.h" But I am not sure if this is a right direction to go in. If a .C user of fsmonitor needs (does not need) things