Re: [PATCH 2/5] progress: return early when in the background

2019-03-25 Thread Luke Mewburn
On 19-03-25 12:39, SZEDER Gábor wrote: | On Mon, Mar 25, 2019 at 12:08:47PM +0100, Ævar Arnfjörð Bjarmason wrote: | > | > On Mon, Mar 25 2019, SZEDER Gábor wrote: | > | > > When a git process runs in the background, it doesn't display | > > progress, only the final "done" line [1]. T

Re: [PATCH 2/5] progress: return early when in the background

2019-03-25 Thread Jeff King
On Mon, Mar 25, 2019 at 11:38:41AM +0100, SZEDER Gábor wrote: > diff --git a/progress.c b/progress.c > index 02a20e7d58..b57c0dae16 100644 > --- a/progress.c > +++ b/progress.c > @@ -86,28 +86,30 @@ static void display(struct progress *progress, uint64_t > n, const char *done) > ret

Re: [PATCH 2/5] progress: return early when in the background

2019-03-25 Thread SZEDER Gábor
On Mon, Mar 25, 2019 at 12:08:47PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Mar 25 2019, SZEDER Gábor wrote: > > > When a git process runs in the background, it doesn't display > > progress, only the final "done" line [1]. The condition to check that > > are a bit too deep in the displa

Re: [PATCH 2/5] progress: return early when in the background

2019-03-25 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 25 2019, SZEDER Gábor wrote: > When a git process runs in the background, it doesn't display > progress, only the final "done" line [1]. The condition to check that > are a bit too deep in the display() function, and thus it calculates > the progress percentage even when no progress

[PATCH 2/5] progress: return early when in the background

2019-03-25 Thread SZEDER Gábor
When a git process runs in the background, it doesn't display progress, only the final "done" line [1]. The condition to check that are a bit too deep in the display() function, and thus it calculates the progress percentage even when no progress will be displayed anyway. Restructure the display(