Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 16:56 +0100, Jakub Narębski wrote: > On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak > wrote: > > > This check will be used in more than one place later. > > > > Signed-off-by: Krzesimir Nowak > > Reviewed-by: Junio C Hamano > > Reviewed-by: Jakub Narębski > > All right

Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 12:31 -0800, Junio C Hamano wrote: > Krzesimir Nowak writes: > > > This check will be used in more than one place later. > > > > Signed-off-by: Krzesimir Nowak > > Reviewed-by: Junio C Hamano > > Again, I do not think I reviewed this exact version. Nor did I say > that us

Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-04 Thread Junio C Hamano
Krzesimir Nowak writes: > This check will be used in more than one place later. > > Signed-off-by: Krzesimir Nowak > Reviewed-by: Junio C Hamano Again, I do not think I reviewed this exact version. Nor did I say that use of the "... or return undef" is a good idea. > Reviewed-by: Jakub Narębs

Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak wrote: > This check will be used in more than one place later. > > Signed-off-by: Krzesimir Nowak > Reviewed-by: Junio C Hamano > Reviewed-by: Jakub Narębski All right, that is nice refactoring. > --- > gitweb/gitweb.perl | 17 +---

[PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-04 Thread Krzesimir Nowak
This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak Reviewed-by: Junio C Hamano Reviewed-by: Jakub Narębski --- gitweb/gitweb.perl | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl ind